Home GnuPG

Deprecate "file.uploadhash"
1e181f0781caUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Deprecate "file.uploadhash"

Summary:
Ref T12464. This is a very old method which let you create a file on the server by referring to data which already existed in another file.

Basically, long ago, arc could say "Do you already have a file with hash X?" and just skip some work if the server did.

arc has not called this method since D13017, in May 2015.

Since it's easy to do so, just make this method pretend that it never has the file. Very old clients will continue to work, since they would expect this response in the common case and continue by uploading data.

Test Plan:

  • Grepped for uploadhash in Phabricator and Arcanist.
  • Called the method with the console, verified it returned null.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12464

Differential Revision: https://secure.phabricator.com/D17618

Details

Provenance
epriestley <git@epriestley.com>Authored on Apr 4 2017, 11:34 PM
Parents
rPHAB873b39be8211: Remove PhabricatorFile::buildFromFileDataOrHash()
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHAB1e181f0781ca: Deprecate "file.uploadhash" (authored by epriestley <git@epriestley.com>).Apr 5 2017, 1:18 AM