Home GnuPG

Apply reviewer changes from Herald via ModularTransactions
216052baf982Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Apply reviewer changes from Herald via ModularTransactions

Summary:
Ref T10967. This converts the reviewer update action in Herald from an older edge write to a newer ModularTransactions write.

The major value from this is that we get a double-write to the new reviewers table.

Test Plan:

  • Wrote a Herald rule to add a reviewer and a blocking reviewer.
  • Saw them added properly to a revision with: no reviewers; both as blocking; A as blocking, B as nonblocking; A as nonblocking, B as blocking.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10967

Differential Revision: https://secure.phabricator.com/D17511

Details

Provenance
epriestley <git@epriestley.com>Authored on Mar 20 2017, 4:33 PM
Parents
rPHABe69f8f717b80: Fix 'Add to Dashboard' issue with builtins
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHAB216052baf982: Apply reviewer changes from Herald via ModularTransactions (authored by epriestley <git@epriestley.com>).Mar 21 2017, 12:42 AM