Home GnuPG

Allow users to resign if they have authority over any reviewer
24b6c7d7186aUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Allow users to resign if they have authority over any reviewer

Summary:
Ref T11050. The old rule was "you can only resign if you're a reviewer".

With the new behavior of "resign", the rule should be "you can resign if you're a reviewer, or you have authority over any reviewer". Make it so.

Also fixes T12446. I don't know how to reproduce that but I'm pretty sure this'll fix it?

Test Plan:

  • Could not resign from a revision with no authority/reviewer.
  • Resigned from a revision with myself as a reviewer.
  • Resigned from a revision with a package I owned as a reviewer.
  • Could not resign from a revision I had already resigned from.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12446, T11050

Differential Revision: https://secure.phabricator.com/D17558

Details

Provenance
epriestley <git@epriestley.com>Authored on Mar 24 2017, 9:02 PM
Parents
rPHABdaeb94561f14: When destroying Calendar events, destroy invitees and notifications
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHAB24b6c7d7186a: Allow users to resign if they have authority over any reviewer (authored by epriestley <git@epriestley.com>).Mar 24 2017, 9:14 PM