Diffusion Phabricator 307b16620734

(stable) Promote 2017 Week 3
307b16620734Unpublished
Actions

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

(no title)

(stable) Promote 2017 Week 3

Details

Provenance

epriestley <git@epriestley.com>

Authored on Jan 21 2017, 3:12 PM

Parents

rPHAB0426ce73f0e6: (stable) Promote 2017 Week 2
rPHABddf82a815b9a: Remove duplicate setIsRequired()

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHAB307b16620734: (stable) Promote 2017 Week 3 (authored by epriestley <git@epriestley.com>).Jan 21 2017, 3:12 PM

Merged Changes

ddf82a815b9a Remove duplicate setIsRequired()
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
d24739ee3cfa Minor consistency/order updates for menu items which reference other objects
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
8113b7691089 Validate menu item fields (links, projects, dashboards, applications, forms…
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
98a29f3de90a Put "View Edit History" above "Remove Comment" in timeline comment action…
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
58c857a6816d Remove motivator panel
Author
Chad Little <chad@phacility.com>
Browse Repository
No Audits
14dfff9c99d2 Mark fields as required on MenuItems
Author
Chad Little <chad@phacility.com>
Browse Repository
No Audits
1bcc8a3d98e0 Remove timeline from Profile Manage
Author
Chad Little <chad@phacility.com>
Browse Repository
No Audits
f8cebdc418e8 Make Differential inline events actually trigger comment preview refreshes
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
a9158d34d46a Show commit audit status in repository history tables, including merge commit…
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
b0dfd42eef29 Don't require edit capability on the Favorites application to edit personal…
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
269dd81f9178 Allow users to re-accept or re-reject a revision if they have authority over…
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
b8e04fe0419d Improve handle batching behavior for commit list view
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
45c3aaeb269e Attempt to make dropdown item actions more consistent
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
90258ed491d5 Fix property shadowing on ActionListView after conversion to TagView
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
35f4514e3ff6 Fancier user menu
Author
Chad Little <chad@phacility.com>
Browse Repository
No Audits
545dad319ec0 Add an "Auditors" rule for Commits
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
a3b067291f85 Add a couple more files to the core JS package
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
b21cd24341c6 When Favorites is uninstalled or not visible to the viewer, hide the menu
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
0513a242352e Fix a bad constant in "audit.query"
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
2d4eb460abb2 Fix MenuItem names not getting attached
Author
Chad Little <chad@phacility.com>
Browse Repository
No Audits
9d3f09ab478e Modularize global quick create builtin items
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
a886969c480f Make documentation items in user menu update as you navigate in Quicksand
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
db65f828ee69 Fix $classes not imploding properly in list view
Author
Chad Little <chad@phacility.com>
Browse Repository
No Audits
d7e5a8b978ad Load global and custom profile menu items in a single query
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
6f5dab634db2 Redesign header menus and search
Author
Chad Little <chad@phacility.com>
Browse Repository
No Audits
23721799fd0b Explicitly warn the user multiple times when they try to register an external…
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
48187cdbbe99 Fix an unusual nonterminating task graph node
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
a4a948561283 Hide dropdown menus when users click workflow items
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
903e37a21b50 Show yellow "draft" bubble in Audit
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
62cf4e6b95ab Remove some remnants of the old ways commit mesage fields worked from…
Author
epriestley <git@epriestley.com>
Browse Repository
No Audits
36e53fd5d010 Remove collapsable option from ProfileMenu
Author
Chad Little <chad@phacility.com>
Browse Repository
No Audits

Changes (99)

Path

Size

resources/

celerity/

map.php

packages.php

sql/

autopatches/

20170119.menuitem.motivator.01.php

src/

__phutil_library_map__.php

applications/

audit/

conduit/

AuditQueryConduitAPIMethod.php

query/

PhabricatorCommitSearchEngine.php

view/

PhabricatorAuditListView.php

auth/

controller/

PhabricatorAuthRegisterController.php

extension/

PhabricatorAuthMainMenuBarExtension.php

base/

PhabricatorApplication.php

celerity/

postprocessor/

CelerityDefaultPostprocessor.php

differential/

conduit/

DifferentialGetCommitMessageConduitAPIMethod.php

customfield/

DifferentialAuditorsField.php

DifferentialBlameRevisionField.php

DifferentialCoreCustomField.php

DifferentialCustomField.php

DifferentialJIRAIssuesField.php

DifferentialRevertPlanField.php

field/

DifferentialCommitMessageCustomField.php

query/

DifferentialRevisionQuery.php

xaction/

DifferentialRevisionAcceptTransaction.php

DifferentialRevisionRejectTransaction.php

DifferentialRevisionReviewTransaction.php

diffusion/

editor/

DiffusionRepositoryEditEngine.php

engine/

DiffusionCommitDraftEngine.php

herald/

DiffusionCommitAuditorsHeraldField.php

query/

DiffusionCommitQuery.php

view/

DiffusionHistoryTableView.php

favorites/

application/

PhabricatorFavoritesApplication.php

constants

PhabricatorFavoritesConstants.php

controller/

PhabricatorFavoritesMainController.php

PhabricatorFavoritesMenuItemController.php

engine/

PhabricatorFavoritesProfileMenuEngine.php

menuitem

PhabricatorFavoritesManageProfileMenuItem.php

help/

controller/

PhabricatorHelpDocumentationController.php

extension

PhabricatorHelpMainMenuBarExtension.php

home/

application/

PhabricatorHomeApplication.php

controller/

PhabricatorHomeQuickCreateController.php

maniphest/

editor/

ManiphestEditEngine.php

people/

controller/

PhabricatorPeopleProfileManageController.php

extension

PhabricatorPeopleMainMenuBarExtension.php

phame/

application/

PhabricatorPhameApplication.php

project/

engine/

PhabricatorProjectEditEngine.php

repository/

storage/

PhabricatorRepositoryAuditRequest.php

PhabricatorRepositoryCommit.php

search/

editor/

PhabricatorProfileMenuEditEngine.php

PhabricatorProfileMenuEditor.php

engine/

PhabricatorProfileMenuEngine.php

menuitem/

PhabricatorApplicationProfileMenuItem.php

PhabricatorDashboardProfileMenuItem.php

PhabricatorEditEngineProfileMenuItem.php

PhabricatorLinkProfileMenuItem.php

PhabricatorMotivatorProfileMenuItem.php

PhabricatorProfileMenuItem.php

PhabricatorProjectProfileMenuItem.php

query/

PhabricatorProfileMenuItemConfigurationQuery.php

storage/

PhabricatorProfileMenuItemConfiguration.php

settings/

extension

PhabricatorSettingsMainMenuBarExtension.php

quickmenu

PhabricatorEditEngineCreateQuickActions.php

PhabricatorQuickActions.php

setting/

PhabricatorProfileMenuCollapsedSetting.php

transactions/

draft/

PhabricatorDraftEngine.php

PhabricatorDraftInterface.php

editengine/

PhabricatorEditEngine.php

infrastructure/

diff/

view/

PHUIDiffGraphView.php

PHUIDiffInlineCommentDetailView.php

__tests__/

PHUIDiffGraphViewTestCase.php

view/

layout/

PhabricatorActionListView.php

PhabricatorActionView.php

page/

PhabricatorStandardPageView.php

menu/

PhabricatorMainMenuSearchView.php

PhabricatorMainMenuView.php

phui/

PHUIButtonView.php

PHUIListItemView.php

PHUIMainMenuView.php

PHUITimelineEventView.php

webroot/

rsrc/

css/

application/

base/

main-menu-view.css

notification-menu.css

phui/

phui-action-list.css

phui-button.css

phui-document-pro.css

phui-form-view.css

phui-profile-menu.css

phui-two-column-view.css

workboards/

phui-workboard.css

js/

application/

aphlict/

behavior-aphlict-dropdown.js

projects/

behavior-project-boards.js

transactions/

behavior-comment-actions.js

core/

behavior-user-menu.js

phui/

behavior-phui-dropdown-menu.js

behavior-phui-profile-menu.js

phuix/

PHUIXActionView.js

PHUIXDropdownMenu.js

rPHAB307b16620734

View Options

resources/celerity/map.php

View Options

resources/celerity/packages.php

View Options

resources/sql/autopatches/20170119.menuitem.motivator.01.php

View Options

src/__phutil_library_map__.php

View Options

src/applications/audit/conduit/AuditQueryConduitAPIMethod.php

View Options

src/applications/audit/query/PhabricatorCommitSearchEngine.php

View Options

src/applications/audit/view/PhabricatorAuditListView.php

View Options

src/applications/auth/controller/PhabricatorAuthRegisterController.php

View Options

src/applications/auth/extension/PhabricatorAuthMainMenuBarExtension.php

View Options

src/applications/base/PhabricatorApplication.php

View Options

src/applications/celerity/postprocessor/CelerityDefaultPostprocessor.php

View Options

src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php

View Options

src/applications/differential/customfield/DifferentialAuditorsField.php

View Options

src/applications/differential/customfield/DifferentialBlameRevisionField.php

View Options

src/applications/differential/customfield/DifferentialCoreCustomField.php

View Options

src/applications/differential/customfield/DifferentialCustomField.php

View Options

src/applications/differential/customfield/DifferentialJIRAIssuesField.php

View Options

src/applications/differential/customfield/DifferentialRevertPlanField.php

View Options

src/applications/differential/field/DifferentialCommitMessageCustomField.php

View Options

src/applications/differential/query/DifferentialRevisionQuery.php

View Options

src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php

View Options

src/applications/differential/xaction/DifferentialRevisionRejectTransaction.php

View Options

src/applications/differential/xaction/DifferentialRevisionReviewTransaction.php

View Options

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php

View Options

src/applications/diffusion/engine/DiffusionCommitDraftEngine.php

View Options

src/applications/diffusion/herald/DiffusionCommitAuditorsHeraldField.php

View Options

src/applications/diffusion/query/DiffusionCommitQuery.php

View Options

src/applications/diffusion/view/DiffusionHistoryTableView.php

View Options

src/applications/favorites/application/PhabricatorFavoritesApplication.php

View Options

src/applications/favorites/constants

View Options

src/applications/favorites/constants/PhabricatorFavoritesConstants.php

View Options

src/applications/favorites/controller/PhabricatorFavoritesMainController.php

View Options

src/applications/favorites/controller/PhabricatorFavoritesMenuItemController.php

View Options

src/applications/favorites/engine/PhabricatorFavoritesProfileMenuEngine.php

View Options

src/applications/favorites/menuitem

View Options

src/applications/favorites/menuitem/PhabricatorFavoritesManageProfileMenuItem.php

View Options

src/applications/help/controller/PhabricatorHelpDocumentationController.php

View Options

src/applications/help/extension

View Options

src/applications/help/extension/PhabricatorHelpMainMenuBarExtension.php

View Options

src/applications/home/application/PhabricatorHomeApplication.php

View Options

src/applications/home/controller/PhabricatorHomeQuickCreateController.php

View Options

src/applications/maniphest/editor/ManiphestEditEngine.php

View Options

src/applications/people/controller/PhabricatorPeopleProfileManageController.php

View Options

src/applications/people/extension

View Options

src/applications/people/extension/PhabricatorPeopleMainMenuBarExtension.php

View Options

src/applications/phame/application/PhabricatorPhameApplication.php

View Options

src/applications/project/engine/PhabricatorProjectEditEngine.php

View Options

src/applications/repository/storage/PhabricatorRepositoryAuditRequest.php

View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

View Options

src/applications/search/editor/PhabricatorProfileMenuEditEngine.php

View Options

src/applications/search/editor/PhabricatorProfileMenuEditor.php

View Options

src/applications/search/engine/PhabricatorProfileMenuEngine.php

View Options

src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php

View Options

src/applications/search/menuitem/PhabricatorDashboardProfileMenuItem.php

View Options

src/applications/search/menuitem/PhabricatorEditEngineProfileMenuItem.php

View Options

src/applications/search/menuitem/PhabricatorLinkProfileMenuItem.php

View Options

src/applications/search/menuitem/PhabricatorMotivatorProfileMenuItem.php

View Options

src/applications/search/menuitem/PhabricatorProfileMenuItem.php

View Options

src/applications/search/menuitem/PhabricatorProjectProfileMenuItem.php

View Options

src/applications/search/query/PhabricatorProfileMenuItemConfigurationQuery.php

View Options

src/applications/search/storage/PhabricatorProfileMenuItemConfiguration.php

View Options

src/applications/settings/extension

View Options

src/applications/settings/extension/PhabricatorSettingsMainMenuBarExtension.php

View Options

src/applications/settings/quickmenu

View Options

src/applications/settings/quickmenu/PhabricatorEditEngineCreateQuickActions.php

View Options

src/applications/settings/quickmenu/PhabricatorQuickActions.php

View Options

src/applications/settings/setting/PhabricatorProfileMenuCollapsedSetting.php

View Options

src/applications/transactions/draft/PhabricatorDraftEngine.php

View Options

src/applications/transactions/draft/PhabricatorDraftInterface.php

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

View Options

src/infrastructure/diff/view/PHUIDiffGraphView.php

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

View Options

src/infrastructure/diff/view/tests/PHUIDiffGraphViewTestCase.php

View Options

src/view/layout/PhabricatorActionListView.php

View Options

src/view/layout/PhabricatorActionView.php

View Options

src/view/page/PhabricatorStandardPageView.php

View Options

src/view/page/menu/PhabricatorMainMenuSearchView.php

View Options

src/view/page/menu/PhabricatorMainMenuView.php

View Options

src/view/phui/PHUIButtonView.php

View Options

src/view/phui/PHUIListItemView.php

View Options

src/view/phui/PHUIMainMenuView.php

View Options

src/view/phui/PHUITimelineEventView.php

View Options

webroot/rsrc/css/application/base/main-menu-view.css

View Options

webroot/rsrc/css/application/base/notification-menu.css

View Options

webroot/rsrc/css/phui/phui-action-list.css

View Options

webroot/rsrc/css/phui/phui-button.css

View Options

webroot/rsrc/css/phui/phui-document-pro.css

View Options

webroot/rsrc/css/phui/phui-form-view.css

View Options

webroot/rsrc/css/phui/phui-profile-menu.css

View Options

webroot/rsrc/css/phui/phui-two-column-view.css

View Options

webroot/rsrc/css/phui/workboards/phui-workboard.css

View Options

webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js

View Options

webroot/rsrc/js/application/projects/behavior-project-boards.js

View Options

webroot/rsrc/js/application/transactions/behavior-comment-actions.js

View Options

webroot/rsrc/js/core/behavior-user-menu.js

View Options

webroot/rsrc/js/phui/behavior-phui-dropdown-menu.js

View Options

webroot/rsrc/js/phui/behavior-phui-profile-menu.js

View Options

webroot/rsrc/js/phuix/PHUIXActionView.js

View Options

webroot/rsrc/js/phuix/PHUIXDropdownMenu.js

(stable) Promote 2017 Week 3307b16620734UnpublishedActions

Unpublished Commit · Learn More

Description

Details

Event Timeline

Merged Changes

Changes (99)

rPHAB307b16620734

resources/celerity/map.php

resources/celerity/packages.php

resources/sql/autopatches/20170119.menuitem.motivator.01.php

src/__phutil_library_map__.php

src/applications/audit/conduit/AuditQueryConduitAPIMethod.php

src/applications/audit/query/PhabricatorCommitSearchEngine.php

src/applications/audit/view/PhabricatorAuditListView.php

src/applications/auth/controller/PhabricatorAuthRegisterController.php

src/applications/auth/extension/PhabricatorAuthMainMenuBarExtension.php

src/applications/base/PhabricatorApplication.php

src/applications/celerity/postprocessor/CelerityDefaultPostprocessor.php

src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php

src/applications/differential/customfield/DifferentialAuditorsField.php

src/applications/differential/customfield/DifferentialBlameRevisionField.php

src/applications/differential/customfield/DifferentialCoreCustomField.php

src/applications/differential/customfield/DifferentialCustomField.php

src/applications/differential/customfield/DifferentialJIRAIssuesField.php

src/applications/differential/customfield/DifferentialRevertPlanField.php

src/applications/differential/field/DifferentialCommitMessageCustomField.php

src/applications/differential/query/DifferentialRevisionQuery.php

src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php

src/applications/differential/xaction/DifferentialRevisionRejectTransaction.php

src/applications/differential/xaction/DifferentialRevisionReviewTransaction.php

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php

src/applications/diffusion/engine/DiffusionCommitDraftEngine.php

src/applications/diffusion/herald/DiffusionCommitAuditorsHeraldField.php

src/applications/diffusion/query/DiffusionCommitQuery.php

src/applications/diffusion/view/DiffusionHistoryTableView.php

src/applications/favorites/application/PhabricatorFavoritesApplication.php

src/applications/favorites/constants

src/applications/favorites/constants/PhabricatorFavoritesConstants.php

src/applications/favorites/controller/PhabricatorFavoritesMainController.php

src/applications/favorites/controller/PhabricatorFavoritesMenuItemController.php

src/applications/favorites/engine/PhabricatorFavoritesProfileMenuEngine.php

src/applications/favorites/menuitem

src/applications/favorites/menuitem/PhabricatorFavoritesManageProfileMenuItem.php

src/applications/help/controller/PhabricatorHelpDocumentationController.php

src/applications/help/extension

src/applications/help/extension/PhabricatorHelpMainMenuBarExtension.php

src/applications/home/application/PhabricatorHomeApplication.php

src/applications/home/controller/PhabricatorHomeQuickCreateController.php

src/applications/maniphest/editor/ManiphestEditEngine.php

src/applications/people/controller/PhabricatorPeopleProfileManageController.php

src/applications/people/extension

src/applications/people/extension/PhabricatorPeopleMainMenuBarExtension.php

src/applications/phame/application/PhabricatorPhameApplication.php

src/applications/project/engine/PhabricatorProjectEditEngine.php

src/applications/repository/storage/PhabricatorRepositoryAuditRequest.php

src/applications/repository/storage/PhabricatorRepositoryCommit.php

src/applications/search/editor/PhabricatorProfileMenuEditEngine.php

src/applications/search/editor/PhabricatorProfileMenuEditor.php

src/applications/search/engine/PhabricatorProfileMenuEngine.php

src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php

src/applications/search/menuitem/PhabricatorDashboardProfileMenuItem.php

src/applications/search/menuitem/PhabricatorEditEngineProfileMenuItem.php

src/applications/search/menuitem/PhabricatorLinkProfileMenuItem.php

src/applications/search/menuitem/PhabricatorMotivatorProfileMenuItem.php

src/applications/search/menuitem/PhabricatorProfileMenuItem.php

src/applications/search/menuitem/PhabricatorProjectProfileMenuItem.php

src/applications/search/query/PhabricatorProfileMenuItemConfigurationQuery.php

src/applications/search/storage/PhabricatorProfileMenuItemConfiguration.php

src/applications/settings/extension

src/applications/settings/extension/PhabricatorSettingsMainMenuBarExtension.php

src/applications/settings/quickmenu

src/applications/settings/quickmenu/PhabricatorEditEngineCreateQuickActions.php

src/applications/settings/quickmenu/PhabricatorQuickActions.php

src/applications/settings/setting/PhabricatorProfileMenuCollapsedSetting.php

src/applications/transactions/draft/PhabricatorDraftEngine.php

src/applications/transactions/draft/PhabricatorDraftInterface.php

src/applications/transactions/editengine/PhabricatorEditEngine.php

src/infrastructure/diff/view/PHUIDiffGraphView.php

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

(stable) Promote 2017 Week 3
307b16620734Unpublished
Actions

src/infrastructure/diff/view/tests/PHUIDiffGraphViewTestCase.php