Home GnuPG

Replace Remarkup calls to `PhabricatorHash::digest()` with SHA256
3a3626834e60Unpublished

Unpublished Commit ยท Learn More

Publishing Disabled: All publishing is disabled for this repository.

Description

Replace Remarkup calls to PhabricatorHash::digest() with SHA256

Summary:
Ref T12509. Many of the calls to HMAC+SHA1 are just to compute cachekeys for remarkup objects.

Make these use HMAC+SHA256 instead. There is no downside to swapping these since they just cause a cache miss in the worst case.

I also plan to get rid of PhabricatorMarkupInterface eventually, but this doesn't go that far.

Test Plan: Browsed some different types of documents (tasks, legalpad documents, phame blogs / posts, pholio mocks, etc).

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12509

Differential Revision: https://secure.phabricator.com/D17631

Details

Provenance
epriestley <git@epriestley.com>Authored on Apr 6 2017, 6:55 PM
marcusPushed on Apr 11 2017, 6:41 PM
Parents
rPHABd450a088906e: Support HMAC+SHA256 with automatic key generation and management
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHAB3a3626834e60: Replace Remarkup calls to `PhabricatorHash::digest()` with SHA256 (authored by epriestley <git@epriestley.com>).Apr 7 2017, 12:43 AM