Home GnuPG

Iterate over ranges correctly for encryped files
45fc4f6f6407Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Iterate over ranges correctly for encryped files

Summary:
Fixes T12079. Currently, when a file is encrypted and a request has "Content-Range", we apply the range first, then decrypt the result. This doesn't work since you can't start decrypting something from somewhere in the middle (at least, not with our cipher selection).

Instead: decrypt the result, then apply the range.

Test Plan: Added failing unit tests, made them pass

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12079

Differential Revision: https://secure.phabricator.com/D17623

Details

Provenance
epriestley <git@epriestley.com>Authored on Apr 5 2017, 3:20 PM
Parents
rPHABf70ff34d97e8: Fix a copy/paste typo with sticky accept
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHAB45fc4f6f6407: Iterate over ranges correctly for encryped files (authored by epriestley <git@epriestley.com>).Apr 5 2017, 6:56 PM