Home GnuPG
Diffusion Phabricator 49a20bde8e6b

Prevent double lightbox in lightbox comments
49a20bde8e6bUnpublished
Actions

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Prevent double lightbox in lightbox comments

Summary: Ref T3612, prevents lightbox from spawning from inside a lightbox.

Test Plan: Click on file lightbox, leave file comment, click file comment, get take to file page instead of another lightbox.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T3612

Differential Revision: https://secure.phabricator.com/D16978

Details

Provenance
Chad Little <chad@phacility.com>Authored on Dec 2 2016, 7:52 PM
Parents
rPHABaa6517a42b35: Make clicking on file icon in lightbox download file
Branches
Unknown
Tags
Unknown

Event Timeline

Chad Little <chad@phacility.com> committed rPHAB49a20bde8e6b: Prevent double lightbox in lightbox comments (authored by Chad Little <chad@phacility.com>).Dec 2 2016, 7:56 PM

Changes (3)

PathSize
resources/
celerity/
src/
view/
page/
webroot/
rsrc/
js/
core/

rPHAB49a20bde8e6b

View Options

resources/celerity/map.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

webroot/rsrc/js/core/behavior-lightbox-attachments.js

Loading...