Home GnuPG

Remove overbearing policy checks in Phame
4b6da9735ba7Unpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Remove overbearing policy checks in Phame

Summary:
Fixes T11584. This controller does unnecessary CAN_EDIT policy checks.

These checks are enforced by EditEngine, and you can make certain types of edits (including comments) even without full-blown edit permission.

Test Plan:

  • Commented as a user without edit permission.
  • Tried to edit as a user without edit permission, was rebuffed with a policy dialog.
  • Edited as a user with edit permission.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11584

Differential Revision: https://secure.phabricator.com/D16493

Details

Event Timeline

epriestley <git@epriestley.com> committed rPHAB4b6da9735ba7: Remove overbearing policy checks in Phame (authored by epriestley <git@epriestley.com>).Sep 5 2016, 9:10 PM