Home GnuPG

Separate commit message parsing and validation from Conduit
552c54668988Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Separate commit message parsing and validation from Conduit

Summary:
Ref T11114. I want to move this step away from custom fields. To start with, isolate all the parsing in one class with a clearer API boundary.

Next, I'll make this class use new field objects to perform parsing, without CustomField interactions.

Test Plan: Created and edited revisions from the CLI, using valid and invalid commit messages.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114

Differential Revision: https://secure.phabricator.com/D17055

Details

Provenance
epriestley <git@epriestley.com>Authored on Dec 14 2016, 4:59 PM
Parents
rPHAB3d8d98bd8deb: Probably (?) fix two very old project slug migrations
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHAB552c54668988: Separate commit message parsing and validation from Conduit (authored by epriestley <git@epriestley.com>).Dec 14 2016, 11:14 PM