Home GnuPG

Re-run config validation from `bin/search`
5f939dcce0f8Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Re-run config validation from bin/search

Summary:
Ref T12450. Normally, we validate config when:

  • You restart the webserver.
  • You edit it with bin/config set ....
  • You edit it with the web UI.

However, you can also change config by editing local.json, some_env.conf.php, a SiteConfig class, etc. In these cases, you may miss config warnings.

Explicitly re-run search config checks from bin/search, similar to the additional database checks we run from bin/storage, to try to produce a better error message if the user has made a configuration error.

Test Plan:

$ ./bin/search init
Usage Exception: Setting "cluster.search" is misconfigured: Invalid search engine type: elastic. Valid types are: elasticsearch, mysql.

Reviewers: chad, 20after4

Reviewed By: 20after4

Maniphest Tasks: T12450

Differential Revision: https://secure.phabricator.com/D17574

Details

Provenance
epriestley <git@epriestley.com>Authored on Mar 28 2017, 10:09 PM
Parents
rPHAB8879118b696f: Fix a mid-air collision around SearchService roles
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHAB5f939dcce0f8: Re-run config validation from `bin/search` (authored by epriestley <git@epriestley.com>).Mar 28 2017, 11:53 PM