Home GnuPG

Modularize content sources
601aaa5a86c1Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Modularize content sources

Summary:
Ref T10537. For Nuance, I want to introduce new sources (like "GitHub" or "GitHub via Nuance" or something) but this needs to modularize eventually.

Split ContentSource apart so applications can add new content sources.

Test Plan:
This change has huge surface area, so I'll hold it until post-release. I think it's fairly safe (and if it does break anything, the breaks should be fatals, not anything subtle or difficult to fix), there's just no reason not to hold it for a few hours.

  • Viewed new module page.
  • Grepped for all removed functions/constants.
  • Viewed some transactions.
  • Hovered over timestamps to get content source details.
  • Added a comment via Conduit.
  • Added a comment via web.
  • Ran bin/storage upgrade --namespace XXXXX --no-quickstart -f to re-run all historic migrations.
  • Generated some objects with bin/lipsum.
  • Ran a bulk job on some tasks.
  • Ran unit tests.

{F1190182}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10537

Differential Revision: https://secure.phabricator.com/D15521

Details

Provenance
epriestley <git@epriestley.com>Authored on Mar 25 2016, 1:56 PM
Parents
rPHABd784d9c0440c: Set blue background (unless it looks terrible)
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHAB601aaa5a86c1: Modularize content sources (authored by epriestley <git@epriestley.com>).Mar 26 2016, 7:59 PM