Home GnuPG
Diffusion Phabricator 69194fdaf510

Make marking comments as "Done" work cleanly on EditEngine
69194fdaf510Unpublished
Actions

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Make marking comments as "Done" work cleanly on EditEngine

Summary: Ref T11114. Fixes T10323.

Test Plan:

  • Marked comments as done only: no warning about not leaving a comment.
  • Did nothing: warning about posting an empty comment.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114, T10323

Differential Revision: https://secure.phabricator.com/D17120

Details

Provenance
epriestley <git@epriestley.com>Authored on Dec 31 2016, 6:57 PM
Parents
rPHABa4ba7daf9009: Add transitional support for mail tags to Differential on EditEngine
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHAB69194fdaf510: Make marking comments as "Done" work cleanly on EditEngine (authored by epriestley <git@epriestley.com>).Dec 31 2016, 7:12 PM

Changes (2)

PathSize
src/
applications/
differential/
editor/

rPHAB69194fdaf510

View Options

src/applications/differential/editor/DifferentialRevisionEditEngine.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...