Home GnuPG

Fix a dashboard bucketing bug
6e9828c743a7Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix a dashboard bucketing bug

Summary: Ref T10939. For various historical reasons, revision status is a numeric string. This comparison fails because it's (string) !== (int). Just use != so this will still work if we turn it into a real string in the future.

Test Plan: Tried a more specific test case locally, got better looking results in "Must Review" and "Should Review".

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10939

Differential Revision: https://secure.phabricator.com/D15928

Details

Event Timeline

epriestley <git@epriestley.com> committed rPHAB6e9828c743a7: Fix a dashboard bucketing bug (authored by epriestley <git@epriestley.com>).May 16 2016, 8:07 PM