Home GnuPG
Diffusion Phabricator 76f07ec80bde

Only require view permissions for read-only Git LFS requests
76f07ec80bdeUnpublished
Actions

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Only require view permissions for read-only Git LFS requests

Summary: Ref T7789. Implement proper detection for read-only requests. Previously, we assumed every request was read/write and required lots of permissions, but we don't need "Can Push" permission if you're only cloning/fetching/pulling.

Test Plan:

  • Set push policy to "no one".
  • Fetched, got clean data out of LFS.
  • Tried to push, got useful error.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T7789

Differential Revision: https://secure.phabricator.com/D15499

Details

Provenance
epriestley <git@epriestley.com>Authored on Mar 19 2016, 6:11 PM
Parents
rPHABd5f9e49e29c1: Use PHUIStatusListView in Diffusion commit list
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHAB76f07ec80bde: Only require view permissions for read-only Git LFS requests (authored by epriestley <git@epriestley.com>).Mar 19 2016, 10:23 PM

Changes (1)

PathSize
src/
applications/
diffusion/
controller/

rPHAB76f07ec80bde

View Options

src/applications/diffusion/controller/DiffusionServeController.php

Loading...