Home GnuPG

Let everyone view Herald rules
78ea6641a204Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Let everyone view Herald rules

Summary:
Ref T9410. This changes the view policy for all Herald rules to the most public policy ("All Users" for private installs, "Public" for public installs).

See T11428 for discussion of this change in greater detail. In practice, this is approximately how things work today anyway, since you can almost always see almost all of this information in transcripts.

I believe this narrower view policy is helpful in zero cases and slightly confusing or harmful in a number of reasonable cases.

Test Plan: Viewed personal, object and global rules as users who could and could not edit the rules.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9410

Differential Revision: https://secure.phabricator.com/D16382

Details

Provenance
epriestley <git@epriestley.com>Authored on Aug 10 2016, 3:01 AM
Parents
rPHABf03214659104: Convert bin/storage workflow to presume utf8mb4 as the default encoding
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHAB78ea6641a204: Let everyone view Herald rules (authored by epriestley <git@epriestley.com>).Aug 10 2016, 5:52 PM