Home GnuPG

Use new Differential bucketing logic on default (non-dashboard) homepage
7ae33d14ec7bUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Use new Differential bucketing logic on default (non-dashboard) homepage

Summary:
Ref T10939. If you haven't installed a dashboard, we show an "Active Revisions" panel on the homepage by default. I waited a bit to update this, but the new buckets don't seem to have caused any major problems so far.

Update this to use the new logic. I'm just showing "must review" + "should review", which is similar to the old beahvior.

Also replace the notification count with this same number. This is a little different from the old behavior, but simpler, and I think we should probably move toward getting rid of these counts completely.

Test Plan:

  • Viewed homepage as logged-in user, saw my revisions (including revisions I have authority over only because of project membership).
  • Saw consistent notification count.
  • Grepped for removed method.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10939

Differential Revision: https://secure.phabricator.com/D15950

Details

Provenance
epriestley <git@epriestley.com>Authored on May 19 2016, 10:28 PM
Parents
rPHAB0fad3847271c: Fix minor section formatting mishap in SSH key email
Branches
Unknown
Tags
Unknown

Event Timeline