Home GnuPG

Migrate old reviewer edges to new storage
8ad5d28686a4Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Migrate old reviewer edges to new storage

Summary:
Ref T10967. We still have double writes, so all reviewers are being written to both old and new storage. This migrates all the data in the old storage to the new storage, so both storage tables should have a complete set of data and be getting identical updates as we move forward.

After this, I can move readers over one at a time and eventually get rid of the old writes and old storage.

This loads all of the edge data into memory in a big chunk. I reached out to one install to get some more information about their data size. Ours is quite manageable and I think even large installs will probably fit into memory, but we can do this in chunks if not.

However, because the Edge table doesn't have an id column, we can't use either the RawMigrationIterator or the MigrationIterator, and would need to write a new EdgeMigrationIterator. This isn't tons of work but might not be necessary.

Test Plan: Ran the migration locally, spot-checked the results in the database for sanity and correctness.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10967

Differential Revision: https://secure.phabricator.com/D17515

Details

Provenance
epriestley <git@epriestley.com>Authored on Mar 20 2017, 6:21 PM
Parents
rPHAB794b456530bc: Store "last comment" and "last action" diffs on reviewers
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHAB8ad5d28686a4: Migrate old reviewer edges to new storage (authored by epriestley <git@epriestley.com>).Mar 21 2017, 12:44 AM