Home GnuPG
Diffusion Phabricator 8aeb7aa52587

Show file comments on file lightboxes
8aeb7aa52587Unpublished
Actions

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Show file comments on file lightboxes

Summary: Basic work in progress, but should show timeline comments for files when in lightbox mode. Looks reasonable.

Test Plan: click on images, see comments from timeline.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T3612

Differential Revision: https://secure.phabricator.com/D16896

Details

Provenance
Chad Little <chad@phacility.com>Authored on Nov 18 2016, 10:23 PM
Parents
rPHAB39509648f2ba: In Calendar mobile month view, color circles green for attending events too
Branches
Unknown
Tags
Unknown

Event Timeline

Chad Little <chad@phacility.com> committed rPHAB8aeb7aa52587: Show file comments on file lightboxes (authored by Chad Little <chad@phacility.com>).Nov 18 2016, 10:24 PM

Changes (15)

PathSize
resources/
celerity/
src/
applications/
files/
application/
controller/
markup/
transactions/
view/
view/
form/
control/
layout/
page/
webroot/
rsrc/
css/
aphront/
phui/
phui/
aphront/
phui-lightbox.css
lightbox-attachment.css
js/
core/

rPHAB8aeb7aa52587

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/files/application/PhabricatorFilesApplication.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileLightboxController.php

Loading...
View Options

src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionView.php

Loading...
View Options

src/view/form/control/PhabricatorRemarkupControl.php

Loading...
View Options

src/view/layout/PhabricatorFileLinkView.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

webroot/rsrc/css/aphront/dialog-view.css

Loading...
View Options

webroot/rsrc/css/aphront/lightbox-attachment.css

Loading...
View Options

webroot/rsrc/css/phui/phui-comment-panel.css

Loading...
View Options

webroot/rsrc/css/phui/phui-lightbox.css

Loading...
View Options

webroot/rsrc/js/core/behavior-lightbox-attachments.js

Loading...