Home GnuPG

(stable) Correct two parameter strictness issues with file uploads
944f7da48670Unpublished

Unpublished Commit ยท Learn More

Publishing Disabled: All publishing is disabled for this repository.

Description

(no title)

(stable) Correct two parameter strictness issues with file uploads

Summary:
Fixes T12531. Strictness fallout from adding typechecking in D17616.

  • chunkedHash is not a real parameter, so the new typechecking was unhappy about it.
  • mime-type no longer allows null.

Test Plan:

  • Ran arc upload --conduit-uri ... 12MB.zero on a 12MB file full of zeroes.
  • Before patch: badness, failure, fallback to one-shot uploads.
  • After patch: success and glory.

Reviewers: chad

Subscribers: joshuaspence

Maniphest Tasks: T12531

Differential Revision: https://secure.phabricator.com/D17651

Details

Provenance
epriestley <git@epriestley.com>Authored on Apr 11 2017, 12:46 AM
marcusPushed on Apr 11 2017, 6:41 PM
Parents
rPHAB699ab153e375: (stable) Promote 2017 Week 14
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHAB944f7da48670: (stable) Correct two parameter strictness issues with file uploads (authored by epriestley <git@epriestley.com>).Apr 11 2017, 1:01 AM