Extract variable type information from pht() calls
980367452522Unpublished
Actions

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Extract variable type information from pht() calls

Summary:
Ref T5267. When extrating data from pht() calls, also extract the argument types and export them into the map so they can be used by consumers.

We recognize plurals (phutil_count(), new PhutilNumber) and genders (phutil_person()). We'll need to annotate the codebase for those, since they're currently runtime-only.

Test Plan:
Rebuilt extraction maps, got data like this (note "number" type annotation).

"Scaling pool \"%s\" up to %s daemon(s).": {
  "uses": [
    {
      "file": "/daemon/PhutilDaemonOverseer.php",
      "line": 378
    }
  ],
  "types": [
    null,
    "number"
  ]
},

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T5267

Differential Revision: https://secure.phabricator.com/D16823