Home GnuPG

Give ConpherenceThreadQuery a primary table alias
a653d4d9b3e1Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Give ConpherenceThreadQuery a primary table alias

Summary: Fixes T11113. On the 2nd+ page, we could end up with an ambiguous id WHERE clause because we don't define a primary table alias on this query. Define one.

Test Plan:
Changed SearchEngine to return pages of size 5, searched for my threads, toggled to second page, no exception.

Used DarkConsole to examine that second-page query, saw that it had thread.id explicitly instead of id implicitly.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11113

Differential Revision: https://secure.phabricator.com/D16080

Details

Provenance
epriestley <git@epriestley.com>Authored on Jun 8 2016, 4:33 PM
Parents
rPHABc71f92a1eba7: Fix new Countdown link
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHABa653d4d9b3e1: Give ConpherenceThreadQuery a primary table alias (authored by epriestley <git@epriestley.com>).Jun 8 2016, 4:39 PM