Home GnuPG

Fix bad JS rendering in "Allow Desktop Notifications" workflow
ab9c1b73b532Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix bad JS rendering in "Allow Desktop Notifications" workflow

Summary:
See downstream https://phabricator.kde.org/T5404. This code was doing some .firstChild shenanigans which didn't survive some UI refactoring.

This whole UI is a little iffy but just unbreak it for now.

Test Plan: Allowed and rejected desktop notifications, got largely reasonable UI rendering.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D17388

Details

Provenance
epriestley <git@epriestley.com>Authored on Feb 20 2017, 9:48 PM
Parents
rPHAB9f3cde4db765: Fix errors found by PHPStan
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHABab9c1b73b532: Fix bad JS rendering in "Allow Desktop Notifications" workflow (authored by epriestley <git@epriestley.com>).Feb 20 2017, 9:55 PM