Home GnuPG

Fix overzealous transactions on dashboard panels
ac729278328eUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix overzealous transactions on dashboard panels

Summary: Fixes T10474. This had the same root cause as T10024 -- a missing call to didSetValueFromStorage() because of the way the fields work.

Test Plan:

  • Edited a text panel before change, without changing text: got silly transaction.
  • Made change, edited text panel without changing text, no transaction.
  • Made a real edit, got a good transaction.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10474

Differential Revision: https://secure.phabricator.com/D15391

Details

Provenance
epriestley <git@epriestley.com>Authored on Mar 3 2016, 2:46 PM
Parents
rPHAB61c45e4927a0: Update Calendar for PHUITwoColumnView
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHABac729278328e: Fix overzealous transactions on dashboard panels (authored by epriestley <git@epriestley.com>).Mar 3 2016, 4:35 PM