Home GnuPG

Remove extra container tag on HandleListViews rendering from…
b08c9b3ffa8aUnpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Remove extra container tag on HandleListViews rendering from ModularTransactions in text mode

Summary:
Fixes T12082. Ref T11114. When modular transaction render a handle list, they use HandleListView, which has a text mode.

However, the HandleListView is a TagView, and currently TagViews always render a tag of some kind. Allow them to return null to decline to render any tag.

Test Plan:

  • Added a pile of debugging stuff to ApplicationTransactionEditor to throw during mail generation.
  • Added a reviewer to a revision.
  • Used bin/worker execute --id ... to hit the mail generation repeatedly.
  • Before patch: mail generated with a <span>, even in text mode.
  • After patch: clean mail generation.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12082, T11114

Differential Revision: https://secure.phabricator.com/D17162

Details

Event Timeline

epriestley <git@epriestley.com> committed rPHABb08c9b3ffa8a: Remove extra container tag on HandleListViews rendering from… (authored by epriestley <git@epriestley.com>).Jan 9 2017, 5:41 PM