Home GnuPG

Allow menu items to be edited again
b2de1490093cUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Allow menu items to be edited again

Summary:
Ref T12174. We now require that we can figure out a valid "edit mode" (global vs custom/personal) before we hit EditEngine. Since the EditEngine routes don't have an itemID, they would failu to figure out the mode and just 404.

Let the engine use id (from EditEngine) if itemID (from MenuEngine) isn't present in the route.

Test Plan:

  • Edited some menu items on Home / Projects.
  • (I think I tested this, then broke it, originally.)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12174

Differential Revision: https://secure.phabricator.com/D17280

Details

Provenance
epriestley <git@epriestley.com>Authored on Jan 31 2017, 10:23 PM
Parents
rPHABf7c381358656: Add Label MenuItem
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHABb2de1490093c: Allow menu items to be edited again (authored by epriestley <git@epriestley.com>).Jan 31 2017, 10:36 PM