Home GnuPG

Fix a possible fatal on the first push to a cluster repository
bb16a1b0e2a8Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix a possible fatal on the first push to a cluster repository

Summary:
Fixes T11020. I think this resolves things -- $new_version (set above) should be used, not $new_log directly.

Specifically, we would get into trouble if the initial push failed for some reason (working copy not initialized yet, commit hook rejected, etc).

Test Plan: Made a bad push to a new repository. Saw it freeze before the patch and succeed afterwards.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11020

Differential Revision: https://secure.phabricator.com/D15969

Details

Provenance
epriestley <git@epriestley.com>Authored on May 24 2016, 2:13 AM
Parents
rPHAB725d60eb4aa8: Fix "Reviewers" validation issue with empty reviewers
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHABbb16a1b0e2a8: Fix a possible fatal on the first push to a cluster repository (authored by epriestley <git@epriestley.com>).May 24 2016, 2:54 AM