Home GnuPG

Split Repository EditEngine form into smaller pages
c0d42a89430aUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Split Repository EditEngine form into smaller pages

Summary:
Ref T10748. This allows an EditEngine form to be broken up into pages.

This is less powerful than PHUIPagedFormView, because the pages are not sequential / stateful. Each form saves immediately once it's submitted, and can not take you to a new form or back/forward in a series of forms.

For example, you can't create a workflow where the user fills out 5 pages of information before we create an object, like the current repository workflow does.

However, the only place we've ever wanted to do this is repositories and it's fairly bad there, so I feel reasonably confident we aren't going to miss this in the future.

(We do "choose a type of service/repository/rule -> fill out one page of info" fairly often, but can do this without the full-power paging stuff.)

Test Plan:

  • Created a repository usin the new Manage UI, filling out only a handful of fields.
  • Edited a repository using the new Manage UI.
  • All forms are now EditEngine forms offering paged views of the big huge underlying form:

{F1254371}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10748

Differential Revision: https://secure.phabricator.com/D15832

Details

Provenance
epriestley <git@epriestley.com>Authored on May 2 2016, 2:35 PM
Parents
rPHAB99718b61d8f3: Fill in new URI credential edit web UI interfaces
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHABc0d42a89430a: Split Repository EditEngine form into smaller pages (authored by epriestley <git@epriestley.com>).May 2 2016, 5:28 PM