Home GnuPG

Add a key to improve Diffusion's cache fill history query
ca4c0db2c185Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Add a key to improve Diffusion's cache fill history query

Summary:
Ref T10560. I don't fully understand what MySQL is doing here, but it looks like this key improves the problematic dataset in practice.

(It makes sense that this key helps, I'm just not sure why the two separate keys and the UNION ALL are so bad.)

This key isn't hugely expensive to add, so we can try it and see if there are still issues.

Test Plan: Ran bin/storage adjust, saw key added to table. Used SHOW CREATE TABLE ... to verify the key exists. Used EXPLAIN SELECT ... to make sure MySQL actually uses it.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10560

Differential Revision: https://secure.phabricator.com/D15460

Details

Provenance
epriestley <git@epriestley.com>Authored on Mar 11 2016, 2:33 AM
Parents
rPHAB8858b6cf8d17: When replying to a ghost comment, attach the reply to the same place
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHABca4c0db2c185: Add a key to improve Diffusion's cache fill history query (authored by epriestley <git@epriestley.com>).Mar 11 2016, 2:38 AM