Home GnuPG

Make the revision graph view more flexible
cc7ae60aaf10Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Make the revision graph view more flexible

Summary:
Ref T4788. This separates the revision graph view into a base class with core logic and a revision class with Differential-specific logic, so I can subclass it in Maniphest, etc., and try using it in other applications to show similar graphs.

Not sure if we'll stick with it, but even if we don't this makes the code a bit cleaner and gets custom rendering logic out of the RevisionViewController, which is nice.

Test Plan: Viewed revisions, saw the stack UI completely unchanged.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4788

Differential Revision: https://secure.phabricator.com/D16213

Details

Provenance
epriestley <git@epriestley.com>Authored on Jul 1 2016, 5:06 PM
Parents
rPHAB791a4ff9733e: Touch up a few tokens
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHABcc7ae60aaf10: Make the revision graph view more flexible (authored by epriestley <git@epriestley.com>).Jul 1 2016, 7:40 PM