Home GnuPG

Make "Can Interact" and logged-out users interact more gracefully
d0c648dfa53bUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Make "Can Interact" and logged-out users interact more gracefully

Summary:
Fixes T12378. Two minor issues here:

  • CAN_INTERACT on tasks uses "USER", but should just use the view policy, which may be more permissive ("PUBLIC").
  • CAN_INTERACT is currently prevented from being "PUBLIC" by additional safeguards. Define an explicit capability object for the permission which returns true from shouldAllowPublicPolicySetting().

Test Plan:

  • Viewed an unlocked task as a logged-out user, saw "login to comment" instead of "locked".
  • Viewed a locked task as a logged-out user, saw "locked".

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12378

Differential Revision: https://secure.phabricator.com/D17485

Details

Provenance
epriestley <git@epriestley.com>Authored on Mar 9 2017, 5:41 PM
Parents
rPHAB4c7d464f8bf2: Fix firefox submenu arrows on action lists
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHABd0c648dfa53b: Make "Can Interact" and logged-out users interact more gracefully (authored by epriestley <git@epriestley.com>).Mar 9 2017, 5:50 PM