Home GnuPG

Remove needRecipients and needAwards from Badges
d2a420d13abdUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Remove needRecipients and needAwards from Badges

Summary: Fixes T10798. Separates these two since they don't need to be combined and it allows for more flexibility / scalability.

Test Plan:

  • Add Badge
  • Edit Badge
  • Add myself as Recipient
  • Remove myself
  • Go to my profile
  • Award Badge from there
  • Assign myself a badge, try to re-assign it, see validation error.

Also, validation errors on dialog forms are ugly.

{F3495630}

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T10798, T12270

Differential Revision: https://secure.phabricator.com/D17447

Details

Provenance
Chad Little <chad@phacility.com>Authored on Mar 3 2017, 5:41 PM
Parents
rPHABc102620a298f: Lock `files.video-mime-types` config option for consistency
Branches
Unknown
Tags
Unknown

Event Timeline

Chad Little <chad@phacility.com> committed rPHABd2a420d13abd: Remove needRecipients and needAwards from Badges (authored by Chad Little <chad@phacility.com>).Mar 3 2017, 5:41 PM