Home GnuPG

Modernize "Responsible Users" tokenizer and add "exact(user)" token
d46378df208fUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Modernize "Responsible Users" tokenizer and add "exact(user)" token

Summary:
Ref T10939. Fixes T9263. Ref T4144.

First, this resolves users (converting users into all packages and projects they are responsible for) earlier, so bucketing can act on that data correctly. Previously, your own blocking reviews would appear in "Must Review" but your packages/projects' would not. Now, all of them will.

Second, this adds exact(username) to mean "just me, not my packages/projects". You can use this along with "Bucket: By Required Action" to create a personal view of "Active Revisions" if you'd like, and ignore all your project/package reviews.

Test Plan: Queried by "me" and "exact(me)", got reasonable looking results.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4144, T9263, T10939

Differential Revision: https://secure.phabricator.com/D15925

Details

Provenance
epriestley <git@epriestley.com>Authored on May 16 2016, 5:31 PM
Parents
rPHAB42d49be47bfc: Change Differential revision buckets to focus on "next required action"
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHABd46378df208f: Modernize "Responsible Users" tokenizer and add "exact(user)" token (authored by epriestley <git@epriestley.com>).May 16 2016, 7:46 PM