Home GnuPG

When voiding "Accept" reviews, also void "Reject" reviews
ddc02ce420a5Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

When voiding "Accept" reviews, also void "Reject" reviews

Summary: Ref T10967. This change is similar to D17566, but for rejects.

Test Plan:

  • Create a revision as A, with reviewer B.
  • Reject as B.
  • Request review as A.
  • Before patch: stuck in "rejected".
  • After patch: transitions back to "needs review".

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10967

Differential Revision: https://secure.phabricator.com/D17568

Details

Provenance
epriestley <git@epriestley.com>Authored on Mar 28 2017, 3:22 PM
Parents
rPHAB415ad784844e: Remove old code for "Request Review" action from Differential
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHABddc02ce420a5: When voiding "Accept" reviews, also void "Reject" reviews (authored by epriestley <git@epriestley.com>).Mar 28 2017, 8:51 PM