Home GnuPG

Add ActionIcon to PHUIListItemView, use in Dashboards
de4e8728b2faUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Add ActionIcon to PHUIListItemView, use in Dashboards

Summary: Extends PHUIListItemView to take an icon, link as an "Action Item" that displays on the right side of the menu link. Does not display on Favorites. This allows for adding edit, external, or other links (documentation?) to any menu item. Right now the secondary link is only visible when the item is selected. This feels right, but if we offer it in other ways, users may always want it visible. We could look at making it onhover.

Test Plan:
Add a bunch of random global and personal dashboards to my menu. Add a menu to Favorites, see no link. Test mobile, link works.

{F4136699}

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D17505

Details

Provenance
Chad Little <chad@phacility.com>Authored on Mar 16 2017, 7:32 PM
Parents
rPHAB19af10df3706: Apply the wordwrap() hack for "To" to PHPMailerLite
Branches
Unknown
Tags
Unknown

Event Timeline

Chad Little <chad@phacility.com> committed rPHABde4e8728b2fa: Add ActionIcon to PHUIListItemView, use in Dashboards (authored by Chad Little <chad@phacility.com>).Mar 16 2017, 7:32 PM