Home GnuPG

Give users an explicit error if they try to upload a too-large diff to…
efba69a44022Unpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Give users an explicit error if they try to upload a too-large diff to Differential

Summary:
Ref T8612. If a change affects more than 10K paths + hunks, tell the user it's too big and don't bother trying to write it. We're mostly bounded by INSERTs here.

Also, fix an issue with file upload errors. The keys are real PHP constants, but were accidentally converted to strings in D12797, causing every error to show as "unknown error".

Test Plan: {F1057509}

Reviewers: joshuaspence

Reviewed By: joshuaspence

Maniphest Tasks: T8612

Differential Revision: https://secure.phabricator.com/D14977

Details

Provenance
epriestley <git@epriestley.com>Authored on Jan 9 2016, 3:44 AM
Parents
rPHAB2c293bdca88d: Fix a missed use of project icons in typehaeads
Branches
Unknown
Tags
Unknown

Event Timeline