Home GnuPG

Add client-side check for protocol mismatch
f0eb6f4fe080Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Add client-side check for protocol mismatch

Summary:
Fixes T10402.
I tried about 50 variations on the wording and notification layout, this seemed by far the most reasonable.
Didn't implement a way to ignore the warning, which might be required - but figured this is serious and broken enough while being completely invisible 99% of the time that it's worth shouting about.

Test Plan: Messed around with $_SERVER['HTTPS'] on the server side and client_uri on the client side - saw reasonable results in all combinations.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley

Maniphest Tasks: T10402

Differential Revision: https://secure.phabricator.com/D16064

Details

Provenance
Asher Baker <asherkin@gmail.com>Authored on Jun 7 2016, 12:01 AM
Parents
rPHAB814fa135b036: Centralize "this is the current user for the request" code
Branches
Unknown
Tags
Unknown

Event Timeline

Asher Baker <asherkin@gmail.com> committed rPHABf0eb6f4fe080: Add client-side check for protocol mismatch (authored by Asher Baker <asherkin@gmail.com>).Jun 7 2016, 5:54 PM