Home GnuPG
Diffusion Phabricator f2a26b260100

When requesting file data, make "Range: bytes=0-" work correctly
f2a26b260100Unpublished
Actions

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

When requesting file data, make "Range: bytes=0-" work correctly

Summary: Ref T12219. Chrome can send requests with a "Range: bytes=0-" header, which just means "the whole file", but we don't respond correctly because of a null vs 0 issue.

Test Plan: Sent a raw bytes=0- request, saw a proper resonse.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12219

Differential Revision: https://secure.phabricator.com/D17627

Details

Provenance
epriestley <git@epriestley.com>Authored on Apr 5 2017, 8:31 PM
Parents
rPHABd1a971e22156: Support "Range: bytes=123-" requests
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHABf2a26b260100: When requesting file data, make "Range: bytes=0-" work correctly (authored by epriestley <git@epriestley.com>).Apr 5 2017, 8:48 PM

Changes (1)

PathSize
src/
aphront/
response/

rPHABf2a26b260100

View Options

src/aphront/response/AphrontFileResponse.php

Loading...