Home GnuPG
Diffusion Phabricator f2f896c761a2

Removed all instances of getIconURI
f2f896c761a2Unpublished
Actions

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Removed all instances of getIconURI

Summary: Fixes T11541. PhabricatorApplication::getIconURI() has been returning only null for a while (I assume in preparation to remove it). I removed the method and all the remaining call sites.

Test Plan: Removed the method and then clicked around. Things didn't explode!

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, yelirekim

Maniphest Tasks: T11541

Differential Revision: https://secure.phabricator.com/D16470

Details

Provenance
Josh Cox <joshcox@uberatc.com>Authored on Aug 29 2016, 11:58 PM
Parents
rPHABb75cea55a782: Fix search results with tables, fatals in Phortune
Branches
Unknown
Tags
Unknown

Event Timeline

Josh Cox <joshcox@uberatc.com> committed rPHABf2f896c761a2: Removed all instances of getIconURI (authored by Josh Cox <joshcox@uberatc.com>).Aug 30 2016, 12:11 AM

Changes (3)

PathSize
src/
applications/
base/
meta/
typeahead/
view/

rPHABf2f896c761a2

View Options

src/applications/base/PhabricatorApplication.php

Loading...
View Options

src/applications/meta/typeahead/PhabricatorApplicationDatasource.php

Loading...
View Options

src/applications/meta/view/PhabricatorApplicationLaunchView.php

Loading...