Home GnuPG
Diffusion Phabricator f557fc9caab1

Return 404 instead of undefined variable error when trying to edit a non…
f557fc9caab1Unpublished
Actions

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Return 404 instead of undefined variable error when trying to edit a non-existent form

Summary: E.g. https://phab-01.wmflabs.org/transactions/editengine/transactions.editengine.config/view/13/

Test Plan:

  • Go to /transactions/editengine/transactions.editengine.config/view/1000000/
  • Observe error
  • Apply patch
  • Observe 404

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D15307

Details

Provenance
Alex Monk <krenair@gmail.com>Authored on Feb 18 2016, 6:54 PM
epriestley <git@epriestley.com>Committed on Feb 18 2016, 6:54 PM
Parents
rPHAB82ca92a9ef1a: Don't show archived project tags on workboard cards
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHABf557fc9caab1: Return 404 instead of undefined variable error when trying to edit a non… (authored by Alex Monk <krenair@gmail.com>).Feb 18 2016, 6:54 PM

Changes (1)

PathSize
src/
applications/
transactions/
controller/

rPHABf557fc9caab1

View Options

src/applications/transactions/controller/PhabricatorEditEngineController.php

Loading...