Home GnuPG

Fix Herald test adapter for commits
f659b8743a01Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix Herald test adapter for commits

Summary:
Fixes T11488. I broke this in D16360, I think by doing a little extra refactoring after testing it.

This code is very old, before commits always needed to have repositories attached in order to do policy checks.

Modernize it by mostly just using the repository which is present on the Commit object, and using the existing edge cache.

Test Plan: Ran a commit through the Herald test adapter.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11488

Differential Revision: https://secure.phabricator.com/D16413

Details

Provenance
epriestley <git@epriestley.com>Authored on Aug 17 2016, 5:34 PM
Parents
rPHABf46cf99274d1: Fix a typo in "Internationalization" documentation
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHABf659b8743a01: Fix Herald test adapter for commits (authored by epriestley <git@epriestley.com>).Aug 17 2016, 6:02 PM