Home GnuPG

Make empty Remarkup table rows have more intuitive behavior
0237d446882cUnpublished

Unpublished Commit ยท Learn More

Publishing Disabled: All publishing is disabled for this repository.

Description

Make empty Remarkup table rows have more intuitive behavior

Summary:
Fixes T12849. Currently, when a row contains only empty cells and cells with "----" in them, we treat it as indicating which cells above should be rendered with <th /> instead of <td />.

This produces an unintuitive result when every cell is empty.

Instead, treat a row as a "headings" row only if it has at least one "---" cell in it.

Test Plan:
Added a unit test.

Note that the resulting row is empty, so it doesn't get normal line height.

{F5008070}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12849

Differential Revision: https://secure.phabricator.com/D18140

Details

Provenance
epriestley <git@epriestley.com>Authored on Jun 20 2017, 12:20 AM
marcusPushed on Jun 27 2017, 9:06 PM
Parents
rPHUTIL900873b4a4c5: Modernize editor selector
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUTIL0237d446882c: Make empty Remarkup table rows have more intuitive behavior (authored by epriestley <git@epriestley.com>).Jun 20 2017, 2:43 PM