Home GnuPG
Diffusion libphutil 1c637275046f

Fixing phutil_utf8_shorten().
1c637275046fUnpublished
Actions

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fixing phutil_utf8_shorten().

Summary: Fixed phutil_utf8_shorten() to be combining character aware.

Test Plan: Unit tests. However, I think I may have not added enough test cases.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin, AnhNhan

Maniphest Tasks: T2379

Differential Revision: https://secure.phabricator.com/D6025

Details

Provenance
Afaque Hussain <Afaque.Hussain@outlook.com>Authored on May 24 2013, 2:15 PM
epriestley <git@epriestley.com>Committed on May 24 2013, 2:15 PM
Parents
rPHUTIL18f49c50f2ca: Provide maximum comparison length onboard PhutilEditDistanceMatrix
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUTIL1c637275046f: Fixing phutil_utf8_shorten(). (authored by Afaque Hussain <Afaque.Hussain@outlook.com>).May 24 2013, 2:15 PM

Changes (2)

PathSize
src/
utils/
__tests__/

rPHUTIL1c637275046f

View Options

src/utils/__tests__/PhutilUTF8TestCase.php

Loading...
View Options

src/utils/utf8.php

Loading...