Home GnuPG

Don't retry queries on connections holding global locks
4b44d03ba60cUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Don't retry queries on connections holding global locks

Summary:
Ref T10860. Currently, if we lose a connection that is holding a MySQL global lock, we may retry the query automatically.

Instead, we should abort, just like we do if we were in the middle of a transaction. Otherwise, code may still think it has the lock and do unsafe things.

Test Plan: See next revision.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10860

Differential Revision: https://secure.phabricator.com/D15789

Details

Provenance
epriestley <git@epriestley.com>Authored on Apr 24 2016, 4:11 PM
Parents
rPHUTIL139d316c4484: Support query timeouts with mysqli on the client side
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUTIL4b44d03ba60c: Don't retry queries on connections holding global locks (authored by epriestley <git@epriestley.com>).Apr 25 2016, 8:20 PM