Home GnuPG

Support class const dereferencing in xhpast
51c179b4c000Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Support class const dereferencing in xhpast

Summary:
Ref T4334. As it turns out, a major overhaul of the syntax wasn't needed.

This adds support for stuff like SomeClass::SOME_CONST[$idx] which was introduced in PHP 7.

Test Plan: Added a test case. Ran tests on libphutil and arcanist with both PHP 5 and PHP 7.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, Firehed

Maniphest Tasks: T4334

Differential Revision: https://secure.phabricator.com/D16138

Details

Provenance
Richard van Velzen <rvanvelzen@experty.com>Authored on Jun 17 2016, 11:50 AM
Parents
rPHUTIL1390fd2e8fdd: Support "x bits in bytes" in phutil_units()
Branches
Unknown
Tags
Unknown

Event Timeline

Richard van Velzen <rvanvelzen@experty.com> committed rPHUTIL51c179b4c000: Support class const dereferencing in xhpast (authored by Richard van Velzen <rvanvelzen@experty.com>).Jun 17 2016, 2:11 PM