Home GnuPG
Diffusion libphutil 5f573d2b7f27

Correctly support try..catch..finally in xhpast
5f573d2b7f27Unpublished
Actions

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Correctly support try..catch..finally in xhpast

Summary: Ref T4334. The catch clauses are optional when a finally is available.

Test Plan: run xhpast with some files. Also added unit tests

Reviewers: joshuaspence, epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: joshuaspence, epriestley, Korvin

Maniphest Tasks: T4334

Differential Revision: https://secure.phabricator.com/D10337

Details

Provenance
Richard van Velzen <rvanvelzen@experty.com>Authored on Mar 17 2016, 12:50 PM
Parents
rPHUTILd20d6e725037: Fix an issue with highlighting PHP snippets with leading whitespace using XHPAST
Branches
Unknown
Tags
Unknown

Event Timeline

Richard van Velzen <rvanvelzen@experty.com> committed rPHUTIL5f573d2b7f27: Correctly support try..catch..finally in xhpast (authored by Richard van Velzen <rvanvelzen@experty.com>).Mar 17 2016, 2:36 PM

Changes (6)

PathSize
src/
parser/
xhpast/
__tests__/
data/
php-only-finally.test
php-empty-heredoc.php.test
php-try-no-catch-or-finally.test
base-fail-syntax.php.test
bin/
support/
xhpast/

rPHUTIL5f573d2b7f27

View Options

src/parser/xhpast/__tests__/data/php-only-finally.test

Loading...
View Options

src/parser/xhpast/__tests__/data/php-try-no-catch-or-finally.test

Loading...
View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Loading...
View Options

support/xhpast/parser.y

Loading...
View Options

support/xhpast/parser.yacc.cpp

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...