Home GnuPG

Don't fatal when encountering [[ <bad URI > | ... ]]
74a1350416ebUnpublished

Unpublished Commit ยท Learn More

Publishing Disabled: All publishing is disabled for this repository.

Description

Don't fatal when encountering ...

Summary:
Fixes T12796. In D17647, the parser became more strict, but this remarkup rule doesn't deal with it gracefully.

Instead, detect when the parse failed and bail out.

Test Plan:

  • Put [[ http://good.com#u:p@evil.com/ | broken ]] into a Remarkup document without backticks.
  • Before patch: fatal ("rejecting ambiguous URI").
  • After patch: link doesn't work (which is correct), but page does.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12796

Differential Revision: https://secure.phabricator.com/D18076

Details

Provenance
epriestley <git@epriestley.com>Authored on Jun 5 2017, 2:44 PM
marcusPushed on Jun 27 2017, 9:06 PM
Parents
rPHUTILa900d7b63e95: In Remarkup, prevent "%%%" on a line from self-terminating the literal block
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUTIL74a1350416eb: Don't fatal when encountering [[ <bad URI > | ... ]] (authored by epriestley <git@epriestley.com>).Jun 5 2017, 6:41 PM