Don't stem "words" with a "." or "_" in them
82f71f62129bUnpublished
Actions

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Don't stem "words" with a "." or "_" in them

Summary: Fixes T12106. It is correct for us to stem "oddly-proportioned", but not "oddlyproportioned.com" or "maniphest.levelup" or "ad_hoc_token_thing".

Test Plan:

Added a bunch of test coverage.
Created a task named "apples.bananas ducks_quacks". Found it by searching for "apples.bananas" and "ducks_quacks".

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12106

Differential Revision: https://secure.phabricator.com/D17330

Details

Provenance

epriestley <git@epriestley.com>

Authored on Feb 9 2017, 8:21 PM

Parents

rPHUTIL9d85dfab0f53: Where available, use async_signals in libphutil

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUTIL82f71f62129b: Don't stem "words" with a "." or "_" in them (authored by epriestley <git@epriestley.com>).Feb 9 2017, 8:30 PM

Changes (2)

Path

Size

src/

search/

PhutilSearchStemmer.php

__tests__/

PhutilSearchStemmerTestCase.php

rPHUTIL82f71f62129b

View Options

src/search/PhutilSearchStemmer.php