Home GnuPG

Increase the severity of "use of undefined constant" to exception
bd4a21319a91Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Increase the severity of "use of undefined constant" to exception

Summary: PHP emits a warning about if (XYZ) (e.g., missing $) and similar and treats it as "XYZ". We never mean "XYZ". In libphutil code, this is always a severe error, and should abort execution.

Test Plan:
Added one to the homepage and got this:

{F36493}

Reviewers: ljalonen

Reviewed By: ljalonen

CC: aran

Differential Revision: https://secure.phabricator.com/D5393

Details

Provenance
epriestley <git@epriestley.com>Authored on Mar 20 2013, 1:54 PM
Parents
rPHUTILf224ea52a701: Implemented a <hr /> remarkup rule
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUTILbd4a21319a91: Increase the severity of "use of undefined constant" to exception (authored by epriestley <git@epriestley.com>).Mar 20 2013, 1:54 PM