Home GnuPG

Add a `phutil_person()` wrapper for the string extractor
c6634479d0f1Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Add a phutil_person() wrapper for the string extractor

Summary:
Ref T5267. When extracting strings, we can currently statically infer information about plurality (via PhutilNumber and phutil_count) but not about gendered variables.

This adds a marker for gendered variables. Usage will be:

pht(
  '%s stood silently.',
  phutil_person($variable));

The string extractor can then annotate this as gendered during extraction.

Also, use more consistent terms for grammatical gender.

Test Plan: arc unit, see next diff.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T5267

Differential Revision: https://secure.phabricator.com/D16822

Details

Provenance
epriestley <git@epriestley.com>Authored on Nov 8 2016, 4:29 PM
Parents
rPHUTIL5dbc2a8e01f6: Add an optional pht() callback for collecting string frequencies
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUTILc6634479d0f1: Add a `phutil_person()` wrapper for the string extractor (authored by epriestley <git@epriestley.com>).Nov 8 2016, 5:32 PM