Paths

Table of Contentst

Include parentheses in n_ARRAY_VALUE_LIST node
d052c489a283Unpublished
Actions

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Include parentheses in n_ARRAY_VALUE_LIST node

Summary: Currently parsing array(1, 2, 3) results in a n_ARRAY_VALUE_LIST with a concrete string of 1, 2, 3. Compare this to list($x, $y) which results in a n_ASSIGNMENT_LIST with a concrete string of ($x, $y).

Test Plan: See next diff.

Reviewers: #blessed_reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D13858

Details

Provenance

Joshua Spence <josh@joshuaspence.com>

Authored on Aug 11 2015, 12:52 PM

Parents

rPHUTILf26954065e59: Use the configuration driven unit test engine

Branches

Unknown

Tags

Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPHUTILd052c489a283: Include parentheses in n_ARRAY_VALUE_LIST node (authored by Joshua Spence <josh@joshuaspence.com>).Aug 11 2015, 2:32 PM

Changes (8)

Path

Size

src/

parser/

xhpast/

__tests__/

data/

php-array-dereference.expect

php-literal-index.php.expect

php-short-array.php.expect

php-syntax.php.expect

bin/

PhutilXHPASTBinary.php

support/

xhpast/

parser.y

parser.yacc.cpp

xhpast.cpp

rPHUTILd052c489a283

View Options

src/parser/xhpast/tests/data/php-array-dereference.expect

View Options

src/parser/xhpast/tests/data/php-literal-index.php.expect

View Options

src/parser/xhpast/tests/data/php-short-array.php.expect

View Options

src/parser/xhpast/tests/data/php-syntax.php.expect

View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

View Options

support/xhpast/parser.y

View Options

support/xhpast/parser.yacc.cpp

View Options

Include parentheses in n_ARRAY_VALUE_LIST noded052c489a283UnpublishedActions

Unpublished Commit · Learn More

Description

Details

Event Timeline

Changes (8)

rPHUTILd052c489a283

src/parser/xhpast/__tests__/data/php-array-dereference.expect

src/parser/xhpast/__tests__/data/php-literal-index.php.expect

src/parser/xhpast/__tests__/data/php-short-array.php.expect

src/parser/xhpast/__tests__/data/php-syntax.php.expect

src/parser/xhpast/bin/PhutilXHPASTBinary.php

support/xhpast/parser.y

support/xhpast/parser.yacc.cpp

support/xhpast/xhpast.cpp

Include parentheses in n_ARRAY_VALUE_LIST node
d052c489a283Unpublished
Actions

src/parser/xhpast/tests/data/php-array-dereference.expect

src/parser/xhpast/tests/data/php-literal-index.php.expect

src/parser/xhpast/tests/data/php-short-array.php.expect

src/parser/xhpast/tests/data/php-syntax.php.expect